[Asterisk-code-review] editline: Avoid shifting a negative signed value. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8067 )

Change subject: editline: Avoid shifting a negative signed value.
......................................................................


Patch Set 1:

+1 (see my issue report) for removing libedit and making it required/essential within the ./configure.

I am getting this issue because libedit is not installed in my system; testing whether there are any issue when only essential deps are present. Furthermore, on OpenBSD and FreeBSD, ./configure is not able to find libedit at all although it is an essential part of these platforms. I am currently investigating this. On the first glance, looks like ./configure requires the tool pkg-config to find libedit currently.


-- 
To view, visit https://gerrit.asterisk.org/8067
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2725048c661c1792d8b1d498575144350b6e9ba
Gerrit-Change-Number: 8067
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sun, 28 Jan 2018 09:16:59 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180128/2d61f460/attachment.html>