[Asterisk-code-review] editline: Avoid shifting a negative signed value. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sat Jan 27 12:56:15 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8067 )

Change subject: editline: Avoid shifting a negative signed value.
......................................................................


Patch Set 1: Code-Review+1

I just checked and it appears this change is already in the latest upstream of libedit.

Side note: the source in main/editline is REALLY REALLY old.  If you're building with it I'd recommend investigating why you are not getting the system installed libedit.  I intend to propose that we remove main/editline from master.


-- 
To view, visit https://gerrit.asterisk.org/8067
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2725048c661c1792d8b1d498575144350b6e9ba
Gerrit-Change-Number: 8067
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 27 Jan 2018 18:56:15 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180127/9e21fc08/attachment.html>


More information about the asterisk-code-review mailing list