[Asterisk-code-review] Branching: Remove unused/old tests that were embedded in a test (testsuite[newmaster])

Corey Farrell asteriskteam at digium.com
Fri Jan 26 18:39:58 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8060 )

Change subject: Branching: Remove unused/old tests that were embedded in a test
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

The sipp scenario deletion is the only thing I'm giving -1 for, the other things can be dealt with later.

https://gerrit.asterisk.org/#/c/8060/1/tests/apps/page/page_predial/test-config.yaml
File tests/apps/page/page_predial/test-config.yaml:

https://gerrit.asterisk.org/#/c/8060/1/tests/apps/page/page_predial/test-config.yaml@22
PS1, Line 22:             minversion: '13.12.0'
Missed this line.


https://gerrit.asterisk.org/#/c/8060/1/tests/channels/SIP/redirecting_reason/tests.yaml
File tests/channels/SIP/redirecting_reason/tests.yaml:

https://gerrit.asterisk.org/#/c/8060/1/tests/channels/SIP/redirecting_reason/tests.yaml@3
PS1, Line 3:     - test: 'v13.8.0'
In another commit before branching lets move v13.8.0 up a dir.


https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/refer_send_to_vm/tests.yaml
File tests/channels/pjsip/refer_send_to_vm/tests.yaml:

https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/refer_send_to_vm/tests.yaml@3
PS1, Line 3:     - test: 'v13.8.0'
In another commit before branching lets move v13.8.0 up a dir.


https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml
File tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml:

https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml@56
PS1, Line 56:                 - { 'key-args': {'scenario': 'alice_v13_8_0.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s',  '-mi': '127.0.0.2'},
Please delete tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml



-- 
To view, visit https://gerrit.asterisk.org/8060
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: newmaster
Gerrit-MessageType: comment
Gerrit-Change-Id: I3688a57452191c13e129c6f924d40ae1398bb24a
Gerrit-Change-Number: 8060
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Sat, 27 Jan 2018 00:39:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180126/b20484e9/attachment-0001.html>


More information about the asterisk-code-review mailing list