<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8060">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">The sipp scenario deletion is the only thing I'm giving -1 for, the other things can be dealt with later.</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/apps/page/page_predial/test-config.yaml">File tests/apps/page/page_predial/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/apps/page/page_predial/test-config.yaml@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> minversion: '13.12.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Missed this line.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/SIP/redirecting_reason/tests.yaml">File tests/channels/SIP/redirecting_reason/tests.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/SIP/redirecting_reason/tests.yaml@3">Patch Set #1, Line 3:</a> <code style="font-family:monospace,monospace"> - test: 'v13.8.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In another commit before branching lets move v13.8.0 up a dir.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/refer_send_to_vm/tests.yaml">File tests/channels/pjsip/refer_send_to_vm/tests.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/refer_send_to_vm/tests.yaml@3">Patch Set #1, Line 3:</a> <code style="font-family:monospace,monospace"> - test: 'v13.8.0'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In another commit before branching lets move v13.8.0 up a dir.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml">File tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8060/1/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml@56">Patch Set #1, Line 56:</a> <code style="font-family:monospace,monospace"> - { 'key-args': {'scenario': 'alice_v13_8_0.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-mi': '127.0.0.2'},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please delete tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8060">change 8060</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8060"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: newmaster </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3688a57452191c13e129c6f924d40ae1398bb24a </div>
<div style="display:none"> Gerrit-Change-Number: 8060 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 27 Jan 2018 00:39:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>