[Asterisk-code-review] loader: Use ast cli completion add for 'module load' complet... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8052 )

Change subject: loader: Use ast_cli_completion_add for 'module load' completion.
......................................................................


Patch Set 3:

I'm not sure how much we care.

This patch eliminates the ability to load modules that are in subdirectories of ast_config_AST_MODULE_DIR.  The previous code would add matching directories to the completion list:

chan_pjsip.so
subdir_modules/
chan_iax2.so

Then if you selected subdir_modules/ completion would search the subdir_module directory.

If you selected a file in subdir_modules the resource name loaded would be:
subdir_modules/my_module.so

The only way to load the modules in the subdirectory is to explicitly request them in modules.conf "load = subdir_modules/my_module.so" or explicitly via cli that we are filling in completion for in this patch.


-- 
To view, visit https://gerrit.asterisk.org/8052
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bf51ffaa7ef1606f3bd1b5bb13f1905d72c6134
Gerrit-Change-Number: 8052
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sat, 27 Jan 2018 00:20:26 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180126/78f3dccf/attachment.html>