<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8052">View Change</a></p><p>Patch set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure how much we care.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This patch eliminates the ability to load modules that are in subdirectories of ast_config_AST_MODULE_DIR.  The previous code would add matching directories to the completion list:</p><p style="white-space: pre-wrap; word-wrap: break-word;">chan_pjsip.so<br>subdir_modules/<br>chan_iax2.so</p><p style="white-space: pre-wrap; word-wrap: break-word;">Then if you selected subdir_modules/ completion would search the subdir_module directory.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you selected a file in subdir_modules the resource name loaded would be:<br>subdir_modules/my_module.so</p><p style="white-space: pre-wrap; word-wrap: break-word;">The only way to load the modules in the subdirectory is to explicitly request them in modules.conf "load = subdir_modules/my_module.so" or explicitly via cli that we are filling in completion for in this patch.</p><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8052">change 8052</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8052"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8bf51ffaa7ef1606f3bd1b5bb13f1905d72c6134 </div>
<div style="display:none"> Gerrit-Change-Number: 8052 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 27 Jan 2018 00:20:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>