[Asterisk-code-review] Add missing OPTIONAL API and ARI dependences. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8007 )

Change subject: Add missing OPTIONAL_API and ARI dependences.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8007/1/res/res_statsd.c
File res/res_statsd.c:

https://gerrit.asterisk.org/#/c/8007/1/res/res_statsd.c@384
PS1, Line 384: AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS, "Statsd client support",
             : 	.support_level = AST_MODULE_SUPPORT_EXTENDED,
             : 	.load = load_module,
             : 	.unload = unload_module,
             : 	.reload = reload_module,
> Should revert this change.
The point of this change is for res_statsd to load after realtime drivers since it uses a config file.  What about .load_pri = AST_MODPRI_CHANNEL_DEPEND - 6?  This would put the module in the correct place, which is not 0.

asterisk/statsd.h is included from app_statsd, res_chan_stats, res_endpoint_stats, res_pjsip and res_pjsip_outbound_registration.  Of these only res_pjsip and res_pjsip_outbound_registration use load_pri.



-- 
To view, visit https://gerrit.asterisk.org/8007
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606
Gerrit-Change-Number: 8007
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 21 Jan 2018 20:47:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180121/663eeb35/attachment.html>