<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8007">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8007/1/res/res_statsd.c">File res/res_statsd.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8007/1/res/res_statsd.c@384">Patch Set #1, Line 384:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS, "Statsd client support",<br>  .support_level = AST_MODULE_SUPPORT_EXTENDED,<br> .load = load_module,<br>  .unload = unload_module,<br>      .reload = reload_module,<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Should revert this change.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The point of this change is for res_statsd to load after realtime drivers since it uses a config file.  What about .load_pri = AST_MODPRI_CHANNEL_DEPEND - 6?  This would put the module in the correct place, which is not 0.</p><p style="white-space: pre-wrap; word-wrap: break-word;">asterisk/statsd.h is included from app_statsd, res_chan_stats, res_endpoint_stats, res_pjsip and res_pjsip_outbound_registration.  Of these only res_pjsip and res_pjsip_outbound_registration use load_pri.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8007">change 8007</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606 </div>
<div style="display:none"> Gerrit-Change-Number: 8007 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 21 Jan 2018 20:47:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>