[Asterisk-code-review] loader: Rework load resource list. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7987 )

Change subject: loader: Rework load_resource_list.
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.asterisk.org/#/c/7987/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1422
PS1, Line 1422: static enum ast_module_load_result load_resource(const char *resource_name, unsigned int suppress_logging, struct module_vector *resource_heap, int required)
How about module_priorities instead of resource_heap.


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1636
PS1, Line 1636: 	struct module_vector resource_heap;
How about module_priorities instead of resource_heap.


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1643
PS1, Line 1643: #define LOAD_RETRIES 4
No longer used.


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1659
PS1, Line 1659: 			ast_debug(3, "PASS %d: %-46s %d\n", attempt, order->resource, lres);
Logged pass is now zero based instead of one based in case you care.


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1663
PS1, Line 1663: 				/* We're supplying a heap so SUCCESS isn't possible but we still have to test for it.
s/a heap/module_priorities/


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1678
PS1, Line 1678: 				/* load_resource worked and the module was added to the priority vector */
s/the priority vector/module_priorities/


https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1703
PS1, Line 1703: 	while ((order = AST_LIST_REMOVE_HEAD(load_order, entry))) {
              : 		ast_free(order->resource);
              : 		ast_free(order);
              : 	}
This should be removed as the caller cleans up load_order.  You eliminated load_retries that this loop used to clean up.



-- 
To view, visit https://gerrit.asterisk.org/7987
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60c15cd57ff9680b62e2a94c7519401fa4a38e45
Gerrit-Change-Number: 7987
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 17 Jan 2018 22:41:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180117/d99eaf8d/attachment.html>