<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7987">View Change</a></p><p>Patch set 1:</p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1422">Patch Set #1, Line 1422:</a> <code style="font-family:monospace,monospace">static enum ast_module_load_result load_resource(const char *resource_name, unsigned int suppress_logging, struct module_vector *resource_heap, int required)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about module_priorities instead of resource_heap.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1636">Patch Set #1, Line 1636:</a> <code style="font-family:monospace,monospace">        struct module_vector resource_heap;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about module_priorities instead of resource_heap.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1643">Patch Set #1, Line 1643:</a> <code style="font-family:monospace,monospace">#define LOAD_RETRIES 4</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No longer used.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1659">Patch Set #1, Line 1659:</a> <code style="font-family:monospace,monospace">                     ast_debug(3, "PASS %d: %-46s %d\n", attempt, order->resource, lres);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Logged pass is now zero based instead of one based in case you care.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1663">Patch Set #1, Line 1663:</a> <code style="font-family:monospace,monospace">                                /* We're supplying a heap so SUCCESS isn't possible but we still have to test for it.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/a heap/module_priorities/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1678">Patch Set #1, Line 1678:</a> <code style="font-family:monospace,monospace">                             /* load_resource worked and the module was added to the priority vector */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/the priority vector/module_priorities/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7987/1/main/loader.c@1703">Patch Set #1, Line 1703:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      while ((order = AST_LIST_REMOVE_HEAD(load_order, entry))) {<br>           ast_free(order->resource);<br>         ast_free(order);<br>      }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be removed as the caller cleans up load_order.  You eliminated load_retries that this loop used to clean up.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7987">change 7987</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7987"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I60c15cd57ff9680b62e2a94c7519401fa4a38e45 </div>
<div style="display:none"> Gerrit-Change-Number: 7987 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Jan 2018 22:41:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>