[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Jan 15 01:21:02 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c@5129
PS6, Line 5129: 	.optional_modules = "res_pjsip_config_wizard",
> If I remember correctly the problem with this module was the unload order. 
So much for going to sleep.  I just tested and things seem to be OK without this dep.  If needed it can be added later.



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 6
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Jan 2018 07:21:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180115/be658d41/attachment.html>


More information about the asterisk-code-review mailing list