[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7872/6/res/res_pjsip.c@5129
PS6, Line 5129: 	.optional_modules = "res_pjsip_config_wizard",
> I don't think res_pjsip should need to know about this module.  Sorcery all
If I remember correctly the problem with this module was the unload order.  When I initially started work on this we had some modules with incorrect load_pri.  It's possible the issue I remember was caused by something that required res_pjsip incorrectly having load_pri = 0 and forcing res_pjsip to load to early.  I'll try doing some more testing tomorrow.

What you suggested about expressing this dependency from res_pjsip_config_wizard would require adding a new field, I'm thinking it would be 'before', so res_pjsip_config_wizard would declare .before = "res_pjsip".  That would result in the same thing as using .optional_modules here.  This is making me feel like maybe I should add a couple `const char *reserved;` fields to ast_module_info.



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 6
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Jan 2018 06:28:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180115/855f30d4/attachment.html>