[Asterisk-code-review] res pjsip.c: Update the endpoint identification documentation. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7890 )

Change subject: res_pjsip.c: Update the endpoint identification documentation.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/7890/1/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/7890/1/configs/samples/pjsip.conf.sample@1115
PS1, Line 1115: ;match= ; Comma separated list of IP addresses, networks, or hostnames to match
              :         ; against (default: "")
              : ;match_header= ; SIP header with specified value to match against (default: "")
> Since you're clarifying, you might want to clarify what happens if you spec
OK, I'll add a note here.


https://gerrit.asterisk.org/#/c/7890/1/res/res_pjsip_endpoint_identifier_ip.c
File res/res_pjsip_endpoint_identifier_ip.c:

https://gerrit.asterisk.org/#/c/7890/1/res/res_pjsip_endpoint_identifier_ip.c@71
PS1, Line 71: 					<description>
            : 						<para>When enabled, <replaceable>srv_lookups</replaceable> will
            : 						perform SRV lookups for _sip._udp, _sip._tcp, and _sips._tcp of
            : 						the given hostnames to determine additional addresses that traffic
            : 						may originate from.
            : 						</para>
            : 					</description>
            : 				</configOption>
            : 				<configOption name="match_header">
            : 					<synopsis>Header/value pair to match against.</synopsis>
            : 					<description>
            : 						<para>A SIP header whose value is used to match against.  SIP
            : 						requests containing the header, along with the specified value,
            : 						will be mapped to the specified endpoint.  The header must be
            : 						specified with a <literal>:</literal>, as in
            : 						<literal>match_header = SIPHeader: value</literal>.
            : 						</para>
            : 					</description>
> Again, might want to clarify what happens when bpoth match and match_header
This was already stated above in the existing description.  ANY matching criteria will constitute a match of the endpoint.



-- 
To view, visit https://gerrit.asterisk.org/7890
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a
Gerrit-Change-Number: 7890
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 09 Jan 2018 19:24:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180109/cfb65c77/attachment.html>