<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7890">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7890/1/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7890/1/configs/samples/pjsip.conf.sample@1115">Patch Set #1, Line 1115:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;match= ; Comma separated list of IP addresses, networks, or hostnames to match<br> ; against (default: "")<br>;match_header= ; SIP header with specified value to match against (default: "")<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Since you're clarifying, you might want to clarify what happens if you spec</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">OK, I'll add a note here.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7890/1/res/res_pjsip_endpoint_identifier_ip.c">File res/res_pjsip_endpoint_identifier_ip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7890/1/res/res_pjsip_endpoint_identifier_ip.c@71">Patch Set #1, Line 71:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <description><br> <para>When enabled, <replaceable>srv_lookups</replaceable> will<br> perform SRV lookups for _sip._udp, _sip._tcp, and _sips._tcp of<br> the given hostnames to determine additional addresses that traffic<br> may originate from.<br> </para><br> </description><br> </configOption><br> <configOption name="match_header"><br> <synopsis>Header/value pair to match against.</synopsis><br> <description><br> <para>A SIP header whose value is used to match against. SIP<br> requests containing the header, along with the specified value,<br> will be mapped to the specified endpoint. The header must be<br> specified with a <literal>:</literal>, as in<br> <literal>match_header = SIPHeader: value</literal>.<br> </para><br> </description><br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Again, might want to clarify what happens when bpoth match and match_header</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This was already stated above in the existing description. ANY matching criteria will constitute a match of the endpoint.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7890">change 7890</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7890"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a </div>
<div style="display:none"> Gerrit-Change-Number: 7890 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Jan 2018 19:24:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>