[Asterisk-code-review] loader: Add dependency fields to module structures. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7872 )

Change subject: loader: Add dependency fields to module structures.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7872/1/include/asterisk/module.h
File include/asterisk/module.h:

https://gerrit.asterisk.org/#/c/7872/1/include/asterisk/module.h@349
PS1, Line 349: 	const char *optional_apis;
> No need, if OPTIONAL_API is disabled anything provided in this
 > field will be treated as if it were in "requires".  

And if it IS enabled?


I will think of
 > how to better word the doxygen.
 > 
 > Example:
 > 'res_adsi' is listed under '.optional_api' in app_voicemail.c but
 > it's listed under '.requires' in app_adsiprog.c and app_getcpeid.c.
 >  That is because app_voicemail can function without res_adsi, but
 > the other two cannot.  If OPTIONAL_API is disabled the module
 > loader will enforce that app_voicemail actually requires res_adsi.

Maybe it'd also help if the field were renamed to "without_optional_api" or "requires_no_optional_api" or something.



-- 
To view, visit https://gerrit.asterisk.org/7872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
Gerrit-Change-Number: 7872
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 09 Jan 2018 15:03:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180109/21d6c377/attachment.html>