<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7872">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7872/1/include/asterisk/module.h">File include/asterisk/module.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/1/include/asterisk/module.h@349">Patch Set #1, Line 349:</a> <code style="font-family:monospace,monospace">      const char *optional_apis;</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">No need, if OPTIONAL_API is disabled anything provided in this<br>field will be treated as if it were in "requires".  </p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">And if it IS enabled?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>I will think of<br> > how to better word the doxygen.<br> > <br> > Example:<br> > 'res_adsi' is listed under '.optional_api' in app_voicemail.c but<br> > it's listed under '.requires' in app_adsiprog.c and app_getcpeid.c.<br> >  That is because app_voicemail can function without res_adsi, but<br> > the other two cannot.  If OPTIONAL_API is disabled the module<br> > loader will enforce that app_voicemail actually requires res_adsi.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe it'd also help if the field were renamed to "without_optional_api" or "requires_no_optional_api" or something.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7872">change 7872</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf </div>
<div style="display:none"> Gerrit-Change-Number: 7872 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Jan 2018 15:03:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>