[Asterisk-code-review] res pjsip.c: Fix endpoint identifier registration name search. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7841 )

Change subject: res_pjsip.c: Fix endpoint identifier registration name search.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c@2576
PS1, Line 2576: 		ast_log(LOG_ERROR, "Unable to add endpoint identifier. Out of memory.\n");
To be honest I think this and all similar allocation failure messages should be removed, leave it to the asterisk/utils.h / main/astmm.c base allocation functions to log failures.  Logging a second message here adds no value.


https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c@2580
PS1, Line 2580: 	id_list_item->name = name;
Should you prevent this value from being NULL as well?



-- 
To view, visit https://gerrit.asterisk.org/7841
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8819ec4b811da8a27419fd93528c54d34f01484
Gerrit-Change-Number: 7841
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 06 Jan 2018 00:34:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/cf922516/attachment.html>