<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7841">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c@2576">Patch Set #1, Line 2576:</a> <code style="font-family:monospace,monospace">         ast_log(LOG_ERROR, "Unable to add endpoint identifier. Out of memory.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">To be honest I think this and all similar allocation failure messages should be removed, leave it to the asterisk/utils.h / main/astmm.c base allocation functions to log failures.  Logging a second message here adds no value.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7841/1/res/res_pjsip.c@2580">Patch Set #1, Line 2580:</a> <code style="font-family:monospace,monospace">      id_list_item->name = name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should you prevent this value from being NULL as well?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7841">change 7841</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib8819ec4b811da8a27419fd93528c54d34f01484 </div>
<div style="display:none"> Gerrit-Change-Number: 7841 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 06 Jan 2018 00:34:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>