[Asterisk-code-review] bridge softmix: Avoid warning about an uninitialized variable. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7821 )

Change subject: bridge_softmix: Avoid warning about an uninitialized variable.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Minor things.

https://gerrit.asterisk.org/#/c/7821/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/7821/2//COMMIT_MSG@7
PS2, Line 7: bridge_softmix: Avoid warning about an uninitialized variable.
Should update the commit message to reflect what is being done.  Something along the lines:

Removed unused parameter from check_binaural_position_change().  Found as a result of the function being passed an uninitialized variable by clang.


https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/bridge_softmix_binaural.c
File bridges/bridge_softmix/bridge_softmix_binaural.c:

https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/bridge_softmix_binaural.c@471
PS2, Line 471: 	struct ast_bridge_channel *bridge_channel = NULL;
This initialization should not be necessary.  It is the loop iteration variable in AST_LIST_TRAVERSE().  Clang was complaining about it because we were passing an uninitialized parameter value to here.


https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/include/bridge_softmix_internal.h
File bridges/bridge_softmix/include/bridge_softmix_internal.h:

https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/include/bridge_softmix_internal.h@380
PS2, Line 380:  * \param bridge_channel The bridge channel.
bridge_channel is no longer a parameter



-- 
To view, visit https://gerrit.asterisk.org/7821
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af3bd84656b685a956d498459f8db3613f68954
Gerrit-Change-Number: 7821
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 05 Jan 2018 22:18:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/d383c137/attachment.html>