<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7821">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Minor things.</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7821/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7821/2//COMMIT_MSG@7">Patch Set #2, Line 7:</a> <code style="font-family:monospace,monospace">bridge_softmix: Avoid warning about an uninitialized variable.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should update the commit message to reflect what is being done.  Something along the lines:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Removed unused parameter from check_binaural_position_change().  Found as a result of the function being passed an uninitialized variable by clang.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/bridge_softmix_binaural.c">File bridges/bridge_softmix/bridge_softmix_binaural.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/bridge_softmix_binaural.c@471">Patch Set #2, Line 471:</a> <code style="font-family:monospace,monospace">      struct ast_bridge_channel *bridge_channel = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This initialization should not be necessary.  It is the loop iteration variable in AST_LIST_TRAVERSE().  Clang was complaining about it because we were passing an uninitialized parameter value to here.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/include/bridge_softmix_internal.h">File bridges/bridge_softmix/include/bridge_softmix_internal.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7821/2/bridges/bridge_softmix/include/bridge_softmix_internal.h@380">Patch Set #2, Line 380:</a> <code style="font-family:monospace,monospace"> * \param bridge_channel The bridge channel.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">bridge_channel is no longer a parameter</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7821">change 7821</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7821"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8af3bd84656b685a956d498459f8db3613f68954 </div>
<div style="display:none"> Gerrit-Change-Number: 7821 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Jan 2018 22:18:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>