[Asterisk-code-review] bridge softmix: Avoid warning about an uninitialized variable. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7819 )

Change subject: bridge_softmix: Avoid warning about an uninitialized variable.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7819/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/7819/1/bridges/bridge_softmix.c@1407
PS1, Line 1407: 		check_binaural_position_change(bridge, softmix_data, bridge_channel);
> I assume the uninitialized variable warning comes from here?  If so I'm not
Actually, looking at the check_binaural_position_change() code the third parameter should not be passed at all.  That function only uses the parameter as the loop iteration variable in an AST_LIST_TRAVERSE() and should be declared as a local variable.



-- 
To view, visit https://gerrit.asterisk.org/7819
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af3bd84656b685a956d498459f8db3613f68954
Gerrit-Change-Number: 7819
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 05 Jan 2018 17:28:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180105/6c3e4119/attachment.html>