[Asterisk-code-review] app followme: Add a prompt to be read when a call is connected (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7741 )

Change subject: app_followme:  Add a prompt to be read when a call is connected
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/7741/1/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/7741/1/CHANGES@3275
PS1, Line 3275:  * Added a new prompt, connecting-prompt, which will be played
              :    (if configured) to the "winner" callee before connecting the call.
              : 
This is the wrong section of the CHANGES file.  This is the functionality changes from v10 to v11 section.  It needs to be  up at the top in a new functionality changes from 13.19.0 to 13.20.0 section.


https://gerrit.asterisk.org/#/c/7741/1/apps/app_followme.c
File apps/app_followme.c:

https://gerrit.asterisk.org/#/c/7741/1/apps/app_followme.c@484
PS1, Line 484:         if ((tmpstr = ast_variable_retrieve(cfg, "general", "connecting-prompt")) && !ast_strlen_zero(tmpstr)) {
             :                 ast_copy_string(connprompt, tmpstr, sizeof(connprompt));
             :         } else if ((tmpstr = ast_variable_retrieve(cfg, "general", "connecting_prompt")) && !ast_strlen_zero(tmpstr)) {
             :                 ast_copy_string(connprompt, tmpstr, sizeof(connprompt));
             :         }
Guidelines: Use tabs not spaces to indent.


https://gerrit.asterisk.org/#/c/7741/1/apps/app_followme.c@1481
PS1, Line 1481:                 /* Play "connecting" message to the winner, if configured. */
Tabs not spaces to indent.



-- 
To view, visit https://gerrit.asterisk.org/7741
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ec1c6c883347f7d1e1f597189544993c8d65272
Gerrit-Change-Number: 7741
Gerrit-PatchSet: 1
Gerrit-Owner: Graham Mainwaring <graham at mhn.org>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 00:02:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180102/c280baa6/attachment.html>