[Asterisk-code-review] app followme: Add a prompt to be read when a call is connected (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7741 )

Change subject: app_followme:  Add a prompt to be read when a call is connected
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7741/1/apps/app_followme.c
File apps/app_followme.c:

https://gerrit.asterisk.org/#/c/7741/1/apps/app_followme.c@1483
PS1, Line 1483: 			ast_stream_and_wait(outbound, targs->connprompt, "");
Before playing the file to the outbound channel you have to call ast_autoservice_start on the caller, and once playback is done you have to call ast_autoservice_stop on the caller.

This is because at this point in time this thread is handling both the caller and the outbound channel. By playing back the audio file you aren't handling the caller, and incoming audio (or other) frames will accumulate and not be read.



-- 
To view, visit https://gerrit.asterisk.org/7741
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ec1c6c883347f7d1e1f597189544993c8d65272
Gerrit-Change-Number: 7741
Gerrit-PatchSet: 1
Gerrit-Owner: Graham Mainwaring <graham at mhn.org>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 12:11:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180102/d1b0e1c7/attachment.html>