[Asterisk-code-review] aco: Add missing aco option type string for OPT TIMELEN T. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7784 )

Change subject: aco: Add missing aco_option_type_string for OPT_TIMELEN_T.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7784/1/main/config_options.c
File main/config_options.c:

https://gerrit.asterisk.org/#/c/7784/1/main/config_options.c@1138
PS1, Line 1138: 	ast_assert(ARRAY_LEN(aco_option_type_string) > type);
> I'm surprised this assert did not fail when the /config/config_options_test
test_config.c doesn't have any XML documentation so I think this is never run for that test.  I'm surprised the test works at all, I thought lack of XMLDOC for aco would spawn errors.

I've created ASTERISK-27540, I'm not fixing the test as part of this review I just want to fix the bug in Asterisk itself.



-- 
To view, visit https://gerrit.asterisk.org/7784
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6c34bb30830be9f7a40823723eb4dcaaa91c61
Gerrit-Change-Number: 7784
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 18:34:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180102/d3011aee/attachment.html>