[Asterisk-code-review] aco: Add missing aco option type string for OPT TIMELEN T. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Jan 2 12:14:45 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7784 )

Change subject: aco: Add missing aco_option_type_string for OPT_TIMELEN_T.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/7784/1/main/config_options.c
File main/config_options.c:

https://gerrit.asterisk.org/#/c/7784/1/main/config_options.c@1138
PS1, Line 1138: 	ast_assert(ARRAY_LEN(aco_option_type_string) > type);
I'm surprised this assert did not fail when the /config/config_options_test unit test is executed before this patch.



-- 
To view, visit https://gerrit.asterisk.org/7784
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6c34bb30830be9f7a40823723eb4dcaaa91c61
Gerrit-Change-Number: 7784
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 02 Jan 2018 18:14:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180102/3afacb6e/attachment.html>


More information about the asterisk-code-review mailing list