[Asterisk-code-review] MALLOC DEBUG: Always use the API. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8366 )

Change subject: MALLOC_DEBUG: Always use the API.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/astmm.h
File include/asterisk/astmm.h:

https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/astmm.h@174
PS1, Line 174: #else
             : #error "NEVER INCLUDE astmm.h DIRECTLY!!"
> Nit: this can be removed as it will be harmless to directly include astmm.h
The point of this is to force people to not include the header inappropriately.


https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/hashtab.h
File include/asterisk/hashtab.h:

https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/hashtab.h@261
PS1, Line 261: #define ast_hashtab_create(initial_buckets, compare, resize, newsize, hash, do_locking) \
> Thank you!  Really hate when macro's have generic a,b,c,d argument names, m
That's why I did it.  I hate useless names too. :)


https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/stringfields.h
File include/asterisk/stringfields.h:

https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/stringfields.h@231
PS1, Line 231: 	/* v-- MALLOC_DEBUG information */
> This is unfortunate.  I know it's just 2 pointers and an int but we use str
Interesting.  It will need to be deferred to another patch.  I don't know if or when it would happen.  That kind of change could only go in master.



-- 
To view, visit https://gerrit.asterisk.org/8366
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic07ad80b2c2df894db984cf27b16a69383ce0e10
Gerrit-Change-Number: 8366
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 23:58:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180222/7acbdde1/attachment.html>