<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8366">View Change</a></p><p>Patch set 1:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/astmm.h">File include/asterisk/astmm.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/astmm.h@174">Patch Set #1, Line 174:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#else<br>#error "NEVER INCLUDE astmm.h DIRECTLY!!"<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Nit: this can be removed as it will be harmless to directly include astmm.h</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The point of this is to force people to not include the header inappropriately.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/hashtab.h">File include/asterisk/hashtab.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/hashtab.h@261">Patch Set #1, Line 261:</a> <code style="font-family:monospace,monospace">#define ast_hashtab_create(initial_buckets, compare, resize, newsize, hash, do_locking) \</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Thank you!  Really hate when macro's have generic a,b,c,d argument names, m</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's why I did it.  I hate useless names too. :)</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/stringfields.h">File include/asterisk/stringfields.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8366/1/include/asterisk/stringfields.h@231">Patch Set #1, Line 231:</a> <code style="font-family:monospace,monospace">  /* v-- MALLOC_DEBUG information */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is unfortunate.  I know it's just 2 pointers and an int but we use str</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Interesting.  It will need to be deferred to another patch.  I don't know if or when it would happen.  That kind of change could only go in master.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8366">change 8366</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8366"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic07ad80b2c2df894db984cf27b16a69383ce0e10 </div>
<div style="display:none"> Gerrit-Change-Number: 8366 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Feb 2018 23:58:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>