[Asterisk-code-review] mkrelease: Delete old release branches (repotools[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8292 )

Change subject: mkrelease: Delete old release branches
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/8292/1/digium_git.py
File digium_git.py:

https://gerrit.asterisk.org/#/c/8292/1/digium_git.py@57
PS1, Line 57: def delete_previous_branch(repo, version):
> What will this do upon release of 16.0.0?  Or in the case of the testsuite 
Whoops yeah find_last_tag returns 'None' if the major branches differ. I should be checking for that instead. Will fix.

As for the second case if the branch does not exist then an exception is thrown by git python which is caught by the digium_git.delete_branch code and continues on. Essentially it becomes a no-op.


https://gerrit.asterisk.org/#/c/8292/1/mkrelease.py
File mkrelease.py:

https://gerrit.asterisk.org/#/c/8292/1/mkrelease.py@435
PS1, Line 435:     if options.project.lower() == 'asterisk':
> I assume this will be expanded to include 'testsuite', or will testsuite be
It's done by other code. One of the other reviews in this series (the testsuite one) handles the testsuite tagging and branch creation/deletion cases.



-- 
To view, visit https://gerrit.asterisk.org/8292
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3928831feef237051c01413ef38ac1e82ffcb9cb
Gerrit-Change-Number: 8292
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 15:47:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180220/566504e5/attachment.html>