[Asterisk-code-review] mkrelease: Delete old release branches (repotools[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8292 )

Change subject: mkrelease: Delete old release branches
......................................................................


Patch Set 1:

(2 comments)

Non-voting comments since I don't know if these are actual problems or just my lack of confidence in how things work in Python combined with the inability for me to test these changes.

https://gerrit.asterisk.org/#/c/8292/1/digium_git.py
File digium_git.py:

https://gerrit.asterisk.org/#/c/8292/1/digium_git.py@57
PS1, Line 57: def delete_previous_branch(repo, version):
What will this do upon release of 16.0.0?  Or in the case of the testsuite when the first release branch is not yet created?

Conditions that I'm wondering about:
# no previous tag
repo.find_last_tag(version) is Nothing
# no previous release branch
prev.branch_name() == '16'


https://gerrit.asterisk.org/#/c/8292/1/mkrelease.py
File mkrelease.py:

https://gerrit.asterisk.org/#/c/8292/1/mkrelease.py@435
PS1, Line 435:     if options.project.lower() == 'asterisk':
I assume this will be expanded to include 'testsuite', or will testsuite be done by some other code?



-- 
To view, visit https://gerrit.asterisk.org/8292
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3928831feef237051c01413ef38ac1e82ffcb9cb
Gerrit-Change-Number: 8292
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 08:22:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180220/c3f56d0c/attachment-0001.html>