[Asterisk-code-review] stasic.c: Fix printf format type mismatches with arguments. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Wed Dec 26 11:04:48 CST 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10826 )

Change subject: stasic.c: Fix printf format type mismatches with arguments.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10826/1/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10826/1/main/stasis.c@2113
PS1, Line 2113: #define FMT_HEADERS		"%-64s %10s %10s %16s %16s\n"
              : #define FMT_FIELDS		"%-64s %10d %10d %16ld %16ld\n"
              : #define FMT_FIELDS2		"%-64s %10d %10d\n"
> Yes it could be used. […]
Given this I'd prefer `struct stasis_subscription_statistics` be changed so lowest_time_invoked and highest_time_invoked are declared int so we won't need to cast them.



-- 
To view, visit https://gerrit.asterisk.org/10826
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 26 Dec 2018 17:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181226/41ec2622/attachment.html>


More information about the asterisk-code-review mailing list