[Asterisk-code-review] stasic.c: Fix printf format type mismatches with arguments. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10826 )

Change subject: stasic.c: Fix printf format type mismatches with arguments.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10826/1/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10826/1/main/stasis.c@2113
PS1, Line 2113: #define FMT_HEADERS		"%-64s %10s %10s %16s %16s\n"
              : #define FMT_FIELDS		"%-64s %10d %10d %16ld %16ld\n"
              : #define FMT_FIELDS2		"%-64s %10d %10d\n"
> Maybe the PRIi64 define should be used here?
Yes it could be used.  I just never can remember what the defines are and they are a real disruption to creating the format string.

Another factor in this case is that those particular variables don't need to be int64_t in size.  They get set with their values by a variable of type int.  See the elapsed variable in subscription_invoke().



-- 
To view, visit https://gerrit.asterisk.org/10826
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 20 Dec 2018 15:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181220/481d3a59/attachment-0001.html>