[Asterisk-code-review] res pjsip: Implement additional SIP RFCs for Google Voice tr... (asterisk[master])

[Michael L. Young]

Michael L. Young has posted comments on this change. ( https://gerrit.asterisk.org/9505 )

Change subject: res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
......................................................................


Patch Set 6:

(5 comments)

https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1160
PS7, Line 1160: 					<synopsis>Google OAuth 2.0 refresh token</synopsis>
If I am understanding the changes, this is not Google specific now with the concept of transport=flow, right?  I would remove reference to Google and just leave it as 'OAuth 2.0 refresh token'


https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1163
PS7, Line 1163: 					<synopsis>Google OAuth 2.0 application's client id</synopsis>
Same comment here.


https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1166
PS7, Line 1166: 					<synopsis>Google OAuth 2.0 application's secret</synopsis>
Same here.


https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c@1414
PS7, Line 1414: /* \brief Get google oauth2 access token using refresh token */
Reference to Google.


https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c@1419
PS7, Line 1419: 	const char *url = "https://www.googleapis.com/oauth2/v3/token";
Perhaps this url should be a config setting?



-- 
To view, visit https://gerrit.asterisk.org/9505
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58
Gerrit-Change-Number: 9505
Gerrit-PatchSet: 6
Gerrit-Owner: Nick French <naf at ou.edu>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Nick French <naf at ou.edu>
Gerrit-Comment-Date: Wed, 29 Aug 2018 03:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180828/2c0333bb/attachment.html>