<p><a href="https://gerrit.asterisk.org/9505">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1160">Patch Set #7, Line 1160:</a> <code style="font-family:monospace,monospace"> <synopsis>Google OAuth 2.0 refresh token</synopsis></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If I am understanding the changes, this is not Google specific now with the concept of transport=flow, right? I would remove reference to Google and just leave it as 'OAuth 2.0 refresh token'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1163">Patch Set #7, Line 1163:</a> <code style="font-family:monospace,monospace"> <synopsis>Google OAuth 2.0 application's client id</synopsis></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same comment here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip.c@1166">Patch Set #7, Line 1166:</a> <code style="font-family:monospace,monospace"> <synopsis>Google OAuth 2.0 application's secret</synopsis></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c@1414">Patch Set #7, Line 1414:</a> <code style="font-family:monospace,monospace">/* \brief Get google oauth2 access token using refresh token */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Reference to Google.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/7/res/res_pjsip_outbound_registration.c@1419">Patch Set #7, Line 1419:</a> <code style="font-family:monospace,monospace"> const char *url = "https://www.googleapis.com/oauth2/v3/token";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Perhaps this url should be a config setting?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9505">change 9505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9505"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58 </div>
<div style="display:none"> Gerrit-Change-Number: 9505 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael L. Young <elgueromexicano@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 29 Aug 2018 03:35:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>