[Asterisk-code-review] res pjsip: Correct various misuses of pjsip rx data.pkt info... (asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Aug 22 16:30:16 CDT 2018


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9984 )

Change subject: res_pjsip: Correct various misuses of pjsip_rx_data.pkt_info.src_name
......................................................................


Patch Set 7:

One last thing to point out - the src_name member is defined as:

 char src_name[PJ_INET6_ADDRSTRLEN]

Where PJ_INET6_ADDRSTRLEN is defined as 46. The length of a full IPv4-mapped IPv6 address is 45 bytes, so there would be no additional room for the []s.


-- 
To view, visit https://gerrit.asterisk.org/9984
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea9d289901b837512bee2ca2535e3dc14f04d77
Gerrit-Change-Number: 9984
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:30:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/7bf65b7c/attachment.html>


More information about the asterisk-code-review mailing list