[Asterisk-code-review] res pjsip: Correct various misuses of pjsip rx data.pkt info... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/9984 )

Change subject: res_pjsip: Correct various misuses of pjsip_rx_data.pkt_info.src_name
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/9984/4/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

https://gerrit.asterisk.org/#/c/9984/4/res/res_pjsip_transport_websocket.c@296
PS4, Line 296: 	pj_ansi_strcpy(rdata->pkt_info.src_name, ast_sockaddr_stringify_addr(ast_websocket_remote_address(session)));
> Asterisk feeds that string to pjsip_tpmgr_find_local_addr2() in
 > res_hep_pjsip.c which I don' t know if it needs []'s or not.
 > 

Ultimately that ends up calling inet_pton() which requires the family argument and is not documented (either in POSIX or Linux man pages) to accept the [] notation, so I think that is a non-issue.



-- 
To view, visit https://gerrit.asterisk.org/9984
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea9d289901b837512bee2ca2535e3dc14f04d77
Gerrit-Change-Number: 9984
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180822/7dc90b12/attachment.html>