[Asterisk-code-review] Fix REF DEBUG issues for most tests/apps. (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Fri Aug 17 09:28:43 CDT 2018


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9922 )

Change subject: Fix REF_DEBUG issues for most tests/apps.
......................................................................


Patch Set 1: Code-Review+1

> 
 > I don't think we can easily inject the pjsip.conf settings.  We
 > could create a global configs/pjsip.conf and configs/pjsip.conf.inc
 > like we have for modules.conf.  So tests would provide
 > pjsip.conf.inc instead of pjsip.conf to get the reduced timer_t1
 > and timer_b values.  I think this would be safe, I'm willing to
 > rework this patch to work this way.
 > 

I think what you have here is fine. Either way one has to remember to add the settings or use the *.inc file.


-- 
To view, visit https://gerrit.asterisk.org/9922
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d96e10c4e339ef9a291fa940ed0fc0bd972aec
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 17 Aug 2018 14:28:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180817/c542daf8/attachment.html>


More information about the asterisk-code-review mailing list