[Asterisk-code-review] Fix REF DEBUG issues for most tests/apps. (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/9922 )

Change subject: Fix REF_DEBUG issues for most tests/apps.
......................................................................


Patch Set 1:

> Think there is an easy/safe way to automate the addition/injection
 > of parameters/settings into the test at run time when running under
 > valgrind or REF_DEBUG?
 > 
 > I just wonder if people don't set the values moving forward on
 > appropriate tests stuff will fail when running under those modes?
 > Maybe not a concern though?
 > 
 > I do recall you not wanting to default 'memcheck-delay-stop' for
 > time reasons (which makes sense).

I don't think we can easily inject the pjsip.conf settings.  We could create a global configs/pjsip.conf and configs/pjsip.conf.inc like we have for modules.conf.  So tests would provide pjsip.conf.inc instead of pjsip.conf to get the reduced timer_t1 and timer_b values.  I think this would be safe, I'm willing to rework this patch to work this way.

As for setting the `memcheck-delay-stop` I think this needs to be done per test that needs it.  If we set the default to 7 seconds we would only rarely need to change it - only a few tests require higher delays.  At most I expect ~400 of the current tests to have memcheck-delay-stop set, nearly 600 tests will work with it set to 0 (current default).  So using a default of 7 seconds for all tests would add 70 minutes to the runtime of the full testsuite.  If memcheck-delay-stop is needed but not set then the test will fail when REF_DEBUG is enabled.

New tests failing to set this will become less of an issue once the entire testsuite can pass with REF_DEBUG enabled, then it'll be easier to see/deal with new issues.


-- 
To view, visit https://gerrit.asterisk.org/9922
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d96e10c4e339ef9a291fa940ed0fc0bd972aec
Gerrit-Change-Number: 9922
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 23:33:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180816/56ce4dbd/attachment.html>