[Asterisk-code-review] bridge softmix / app confbridge: Add support for REMB combin... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8782 )

Change subject: bridge_softmix / app_confbridge: Add support for REMB combining.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

Just need some doxygen notes and a couple asserts to help enforce the notes.  Looks fine otherwise.

https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h
File include/asterisk/bridge.h:

https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h@940
PS2, Line 940: void ast_bridge_set_remb_send_interval(struct ast_bridge *bridge, unsigned int remb_send_interval);
I think a prerequisite note that this can be called only if SFU mode is enabled is needed.  Otherwise we'll mess up some other mode's settings.


https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h@948
PS2, Line 948: void ast_brige_set_remb_behavior(struct ast_bridge *bridge, enum ast_bridge_video_sfu_remb_behavior behavior);
I think a prerequisite note that this can be called only if SFU mode is enabled is needed.  Otherwise we'll mess up some other mode's settings.


https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c
File main/bridge.c:

https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c@3838
PS2, Line 3838: 	bridge->softmix.video_mode.mode_data.sfu_data.remb_send_interval = remb_send_interval;
I think an assert checking that SFU mode is enabled would be useful.


https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c@3845
PS2, Line 3845: 	bridge->softmix.video_mode.mode_data.sfu_data.remb_behavior = behavior;
I think an assert checking that SFU mode is enabled would be useful.



-- 
To view, visit https://gerrit.asterisk.org/8782
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eafe4e7c1f72d67074a8d6acb26bfcf19322b66
Gerrit-Change-Number: 8782
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 17:20:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180417/5a43f88e/attachment.html>