<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8782">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just need some doxygen notes and a couple asserts to help enforce the notes.  Looks fine otherwise.</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h">File include/asterisk/bridge.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h@940">Patch Set #2, Line 940:</a> <code style="font-family:monospace,monospace">void ast_bridge_set_remb_send_interval(struct ast_bridge *bridge, unsigned int remb_send_interval);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think a prerequisite note that this can be called only if SFU mode is enabled is needed.  Otherwise we'll mess up some other mode's settings.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8782/2/include/asterisk/bridge.h@948">Patch Set #2, Line 948:</a> <code style="font-family:monospace,monospace">void ast_brige_set_remb_behavior(struct ast_bridge *bridge, enum ast_bridge_video_sfu_remb_behavior behavior);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think a prerequisite note that this can be called only if SFU mode is enabled is needed.  Otherwise we'll mess up some other mode's settings.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c">File main/bridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c@3838">Patch Set #2, Line 3838:</a> <code style="font-family:monospace,monospace">  bridge->softmix.video_mode.mode_data.sfu_data.remb_send_interval = remb_send_interval;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think an assert checking that SFU mode is enabled would be useful.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8782/2/main/bridge.c@3845">Patch Set #2, Line 3845:</a> <code style="font-family:monospace,monospace">        bridge->softmix.video_mode.mode_data.sfu_data.remb_behavior = behavior;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think an assert checking that SFU mode is enabled would be useful.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8782">change 8782</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8782"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9eafe4e7c1f72d67074a8d6acb26bfcf19322b66 </div>
<div style="display:none"> Gerrit-Change-Number: 8782 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Apr 2018 17:20:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>