[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[13])

George Joseph asteriskteam at digium.com
Tue Apr 17 09:24:25 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8762 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/8762/2/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4888
PS2, Line 4888: 	if (ast_channel_tech(chan)->write_text
> We did not allow anything other than text/plain before and the old methods 
Done


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4897
PS2, Line 4897: 		f.datalen = body_len;
> This is a behavior change as we discarded empty text messages before.
Done



-- 
To view, visit https://gerrit.asterisk.org/8762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 14:24:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180417/9f190fb5/attachment-0001.html>


More information about the asterisk-code-review mailing list