[Asterisk-code-review] bridge softmix: Forward TEXT frames (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8762 )

Change subject: bridge_softmix:  Forward TEXT frames
......................................................................


Patch Set 2:

(7 comments)

https://gerrit.asterisk.org/#/c/8762/3/funcs/func_frame_trace.c
File funcs/func_frame_trace.c:

https://gerrit.asterisk.org/#/c/8762/3/funcs/func_frame_trace.c@377
PS3, Line 377: 	case AST_FRAME_NULL:
> The indention is off by one.
Done


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c
File main/channel.c:

https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4878
PS2, Line 4878: 	size_t body_len = strlen(body) + 1;
> This is only used by the T.140 section so it should be moved there.  The T.
Done


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4898
PS2, Line 4898: 		f.data.ptr = ast_strdup(body);
> You lost the allocation NULL check when you "moved" the code from ast_sendt
Done


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4916
PS2, Line 4916: 		ast_debug(1, "Unable to send text message on channel '%s'\n", ast_channel_name(chan));
> "Channel technology does not support sending text on channel '%s'\n"
Done


https://gerrit.asterisk.org/#/c/8762/2/main/channel.c@4932
PS2, Line 4932: 			.value = (char *)text,
> Did you miss this one?  Or are you assuming that nobody will call this with
Done


https://gerrit.asterisk.org/#/c/8762/3/main/message.c
File main/message.c:

https://gerrit.asterisk.org/#/c/8762/3/main/message.c@1390
PS3, Line 1390: 	for(i=0; i < count; i++) {
> for (i = 0;...
Done


https://gerrit.asterisk.org/#/c/8762/3/main/message.c@1411
PS3, Line 1411: 	for(i=0; i < count; i++) {
> for (i = 0;..
Done



-- 
To view, visit https://gerrit.asterisk.org/8762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489
Gerrit-Change-Number: 8762
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 14:07:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180417/66a40b56/attachment.html>