[Asterisk-code-review] res pjsip.c: Split ast sip push task synchronous() to fit ex... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8745 )

Change subject: res_pjsip.c: Split ast_sip_push_task_synchronous() to fit expectations.
......................................................................


Patch Set 2:

(1 comment)

Yes I ran the testsuite without issues other than the normal ones my test box has.

https://gerrit.asterisk.org/#/c/8745/2/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/8745/2/include/asterisk/res_pjsip.h@1579
PS2, Line 1579: Otherwise, the specified serializer
              :  * executes the task and the current thread waits for it to complete.
> Was this specific behavior done to mirror previous behavior?
Yes this was created to have the previous behavior and be explicit about it because of deadlocks with the pjsip monitor thread.  Otherwise it would not exist.  Passing in a serializer is honored if and only if the current thread is not registered as a pjsip servant thread.

FYI, The pjsip monitor thread is not a serializer but it is a pjsip servant thread because it is registered with pjproject.



-- 
To view, visit https://gerrit.asterisk.org/8745
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id040fa42c0e5972f4c8deef380921461d213b9f3
Gerrit-Change-Number: 8745
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 14:51:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/2e4c7176/attachment.html>