[Asterisk-code-review] res pjsip.c: Split ast sip push task synchronous() to fit ex... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8745 )

Change subject: res_pjsip.c: Split ast_sip_push_task_synchronous() to fit expectations.
......................................................................


Patch Set 2:

(1 comment)

Did you also execute a full testsuite run against this?

https://gerrit.asterisk.org/#/c/8745/2/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/8745/2/include/asterisk/res_pjsip.h@1579
PS2, Line 1579: Otherwise, the specified serializer
              :  * executes the task and the current thread waits for it to complete.
Was this specific behavior done to mirror previous behavior?

Since things are now split up it just seems slightly odd. "This could execute now in a different serializer, or it could execute in the right one". Passing the serializer doesn't really have much meaning then except saving you from choosing a random one.



-- 
To view, visit https://gerrit.asterisk.org/8745
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id040fa42c0e5972f4c8deef380921461d213b9f3
Gerrit-Change-Number: 8745
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 11:40:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180411/49b9c505/attachment.html>