[Asterisk-code-review] bridge: Change participant SFU streams when source streams c... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6529 )

Change subject: bridge: Change participant SFU streams when source streams change.
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/6529/3/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/6529/3/bridges/bridge_softmix.c@1052
PS3, Line 1052: 
Nit.  Should remove this blank line as the following test is done specifically to see if the previous action failed.


https://gerrit.asterisk.org/#/c/6529/3/include/asterisk/frame.h
File include/asterisk/frame.h:

https://gerrit.asterisk.org/#/c/6529/3/include/asterisk/frame.h@304
PS3, Line 304: 	AST_CONTROL_STREAM_TOPOLOGY_SOURCE_CHANGED = 37,    /*!< Channel indication that one of the source streams has changed its source */
Need to add an ignore case to chan_pjsip (probably other techs as well) for this control frame just like we did for CONTROL_STREAM_TOPOLOGY_CHANGED.  The simple bridge will pass it to the peer.


https://gerrit.asterisk.org/#/c/6529/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6529/3/res/res_pjsip_session.c@1489
PS3, Line 1489: 				/* We only count streams that have not been removed */
              : 				if (ast_stream_get_state(stream) != AST_STREAM_STATE_REMOVED) {
              : 					++type_streams[ast_stream_get_type(stream)];
              : 				}
I think this change becomes unnecessary in light of Ben Ford's crash patch.



-- 
To view, visit https://gerrit.asterisk.org/6529
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07
Gerrit-Change-Number: 6529
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 17:07:41 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170921/a538e99e/attachment-0001.html>