<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6529">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6529/3/bridges/bridge_softmix.c">File bridges/bridge_softmix.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6529/3/bridges/bridge_softmix.c@1052">Patch Set #3, Line 1052:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit.  Should remove this blank line as the following test is done specifically to see if the previous action failed.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6529/3/include/asterisk/frame.h">File include/asterisk/frame.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6529/3/include/asterisk/frame.h@304">Patch Set #3, Line 304:</a> <code style="font-family:monospace,monospace">  AST_CONTROL_STREAM_TOPOLOGY_SOURCE_CHANGED = 37,    /*!< Channel indication that one of the source streams has changed its source */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to add an ignore case to chan_pjsip (probably other techs as well) for this control frame just like we did for CONTROL_STREAM_TOPOLOGY_CHANGED.  The simple bridge will pass it to the peer.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6529/3/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6529/3/res/res_pjsip_session.c@1489">Patch Set #3, Line 1489:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                         /* We only count streams that have not been removed */<br>                                if (ast_stream_get_state(stream) != AST_STREAM_STATE_REMOVED) {<br>                                       ++type_streams[ast_stream_get_type(stream)];<br>                          }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this change becomes unnecessary in light of Ben Ford's crash patch.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6529">change 6529</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6529"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07 </div>
<div style="display:none"> Gerrit-Change-Number: 6529 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Sep 2017 17:07:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>