[Asterisk-code-review] bridge : Fix one-way direct-media when early bridging with n... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6495 )

Change subject: bridge : Fix one-way direct-media when early bridging with native_rtp
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6495/1/main/bridge_channel.c
File main/bridge_channel.c:

https://gerrit.asterisk.org/#/c/6495/1/main/bridge_channel.c@2263
PS1, Line 2263: 			bridge->reconfigured = 1;
              : 			bridge_reconfigured(bridge, 0);
The bridge must be locked when calling bridge_reconfigured().  Also you cannot access bridge_channel->bridge without the bridge locked to ensure that the bridge pointer does not change.  A channel can be moved to another bridge at any time unless the bridge is locked.

ast_bridge_channel_lock_bridge(bridge_channel);
bridge_channel->bridge->reconfigured = 1;
bridge_reconfigured(bridge_channel->bridge, 0);
ast_bridge_unlock(bridge_channel->bridge);



-- 
To view, visit https://gerrit.asterisk.org/6495
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df
Gerrit-Change-Number: 6495
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 18 Sep 2017 22:41:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170918/5cf68467/attachment.html>