<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6495">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6495/1/main/bridge_channel.c">File main/bridge_channel.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6495/1/main/bridge_channel.c@2263">Patch Set #1, Line 2263:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                      bridge->reconfigured = 1;<br>                  bridge_reconfigured(bridge, 0);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The bridge must be locked when calling bridge_reconfigured().  Also you cannot access bridge_channel->bridge without the bridge locked to ensure that the bridge pointer does not change.  A channel can be moved to another bridge at any time unless the bridge is locked.</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_bridge_channel_lock_bridge(bridge_channel);<br>bridge_channel->bridge->reconfigured = 1;<br>bridge_reconfigured(bridge_channel->bridge, 0);<br>ast_bridge_unlock(bridge_channel->bridge);</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6495">change 6495</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6495"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df </div>
<div style="display:none"> Gerrit-Change-Number: 6495 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jean Aunis - Prescom <jean.aunis@prescom.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Sep 2017 22:41:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>