[Asterisk-code-review] res rtp asterisk.c: Make strict RTP learning more flexible. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri Sep 8 05:11:26 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6410 )

Change subject: res_rtp_asterisk.c: Make strict RTP learning more flexible.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6410/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6410/1/res/res_rtp_asterisk.c@5145
PS1, Line 5145: 		if (!ast_sockaddr_cmp(&rtp->strict_rtp_address, &addr)) {
The RFC uses an SSRC based approach instead of strictly host and IP address. Thoughts on whether it is reasonable to leverage that here by allowing traffic through if the SSRC is the same and updating the strict address information?



-- 
To view, visit https://gerrit.asterisk.org/6410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2d3aa6e0f22906c25971e74f10027d96525f31c
Gerrit-Change-Number: 6410
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 08 Sep 2017 10:11:26 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170908/2f89f94e/attachment.html>


More information about the asterisk-code-review mailing list