[Asterisk-code-review] res rtp asterisk.c: Make strict RTP learning more flexible. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6410 )

Change subject: res_rtp_asterisk.c: Make strict RTP learning more flexible.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6410/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6410/1/res/res_rtp_asterisk.c@5102
PS1, Line 5102: 		if (!ast_sockaddr_isnull(&rtp->strict_rtp_address)
              : 			&& STRICT_RTP_LEARN_TIMEOUT < ast_tvdiff_ms(ast_tvnow(), rtp->rtp_source_learn.start)) {
              : 			ast_verb(4, "%p -- Strict RTP learning complete - Locking on source address %s\n",
              : 				rtp, ast_sockaddr_stringify(&rtp->strict_rtp_address));
This needs a comment explaining why, the scenario, and the implications.



-- 
To view, visit https://gerrit.asterisk.org/6410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2d3aa6e0f22906c25971e74f10027d96525f31c
Gerrit-Change-Number: 6410
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 07 Sep 2017 09:34:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170907/e09624f7/attachment.html>