[Asterisk-code-review] core / pjsip: Add support for grouping streams together. (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6936 )

Change subject: core / pjsip: Add support for grouping streams together.
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

https://gerrit.asterisk.org/#/c/6936/3/main/stream.c
File main/stream.c:

https://gerrit.asterisk.org/#/c/6936/3/main/stream.c@70
PS3, Line 70: 	 * \brief The group that the stream is part of
            : 	 */
            : 	int group;
> I didn't want to cross that barrier and move protocol knowledge (mslabel, m
I agree. You've got a group already on it, so I was thinking more of adding an id (not a specific protocol label). Then make both id and group guids. In the case of a particular protocol it might be a one to one map. Other consumers might differ somewhat.


https://gerrit.asterisk.org/#/c/6936/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6936/3/res/res_pjsip_session.c@611
PS3, Line 611: 		if (ast_strlen_zero(group_session_media->remote_mslabel) ||
             : 			strcmp(group_session_media->remote_mslabel, session_media->remote_mslabel)) {
> That does get broken apart above in the msid handling. The strsep separates
Ah yes you are correct. I missed that.



-- 
To view, visit https://gerrit.asterisk.org/6936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad
Gerrit-Change-Number: 6936
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 31 Oct 2017 17:12:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171031/d828f8b0/attachment.html>